linux-kernel - Re: [PATCH v2] ath9k: use hw_random API instead of directly dumping into random.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 11:43:04 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     miaoqing@...eaurora.org, Rui Salvaterra <rsalvaterra@...il.com>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        "Sepehrdad, Pouyan" <pouyans@....qualcomm.com>,
        ath9k-devel <ath9k-devel@....qualcomm.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        LKML <linux-kernel@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH v2] ath9k: use hw_random API instead of directly dumping
 into random.c

Hi Florian,

On Wed, Feb 16, 2022 at 4:13 AM Florian Fainelli <f.fainelli@...il.com> wrote:
> You will have to give this instance an unique name because there can be
> multiple ath9k adapters registered in a given system (like Wi-Fi
> routers), and one of the first thing hwrng_register() does is ensure
> that there is not an existing rng with the same name.
>
> Maybe using a combination of ath9k + dev_name() ought to be unique enough?

Good point. Will do. dev_name() probably won't cut it because of
namespaces, but I can always just attach a counter. Will do that for
v3.

Jason