linux-kernel - RE: [PATCH v3 5/6] dt-bindings: Document Tegra234 HDA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 10:54:21 +0000
From:   Mohan Kumar D <mkumard@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Sameer Pujar <spujar@...dia.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 5/6] dt-bindings: Document Tegra234 HDA support

Hi Krzysztof Kozlowski, 
The current order is intentional to reflect the new->old chip, the top entry is newer chip. If needed we can add comment to reflect this info.

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> 
Sent: Wednesday, February 16, 2022 4:00 PM
To: Mohan Kumar D <mkumard@...dia.com>; broonie@...nel.org; lgirdwood@...il.com; robh+dt@...nel.org; thierry.reding@...il.com; tiwai@...e.com; Jonathan Hunter <jonathanh@...dia.com>; Sameer Pujar <spujar@...dia.com>
Cc: alsa-devel@...a-project.org; devicetree@...r.kernel.org; linux-tegra@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/6] dt-bindings: Document Tegra234 HDA support

External email: Use caution opening links or attachments


On 16/02/2022 10:22, Mohan Kumar wrote:
> Update binding document for HDA support on Tegra234 chip.
>
> Tegra234 has max of 2 clocks and 2 resets which requires to add 
> minItems and maxItems for clocks and resets as Tegra chips can now 
> have minimum of 2 and maximum of 3 clocks and reset support.
>
> Signed-off-by: Mohan Kumar <mkumard@...dia.com>
> ---
>  .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git 
> a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml 
> b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index 2c913aa44fee..12c31b4b99e1 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -23,6 +23,7 @@ properties:
>        - const: nvidia,tegra30-hda
>        - items:
>            - enum:
> +              - nvidia,tegra234-hda

Why putting it in non-alphabetical order? Although someone put nvidia,tegra124-hda already at the end of list... having things ordered is helpful to avoid conflicts and makes code easier to read.


Best regards,
Krzysztof