linux-kernel - Re: [v11,1/3] drm/dsi: transfer DSI HS packets ending at the same time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55c380797ef845992c0d1a7f1d15b986eaf478c0.camel@mediatek.com>
Date:   Wed, 16 Feb 2022 19:36:00 +0800
From:   Rex-BC Chen <rex-bc.chen@...iatek.com>
To:     <chunkuang.hu@...nel.org>, <matthias.bgg@...il.com>,
        <narmstrong@...libre.com>, <robert.foss@...aro.org>,
        <andrzej.hajda@...el.com>, <daniel@...ll.ch>, <airlied@...ux.ie>,
        <maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
        <tzimmermann@...e.de>, <p.zabel@...gutronix.de>
CC:     <xji@...logixsemi.com>, <jitao.shi@...iatek.com>,
        <xinlei.lee@...iatek.com>,
        <angelogioacchino.delregno@...labora.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [v11,1/3] drm/dsi: transfer DSI HS packets ending at the same
 time

Hello common DRM maintainers,

We have proposed a DSI mode_flag definition in
include/drm/drm_mipi_dsi.h.
The maintainer of bridge chip, Andrzej, also reviewed this patch.

Is there any chance that you can give us some suggestions?
We also need your approvement if this series is acceptable.

Also, if the patch is not proper for you, please let us know.

Thanks for your help.

BRs,
Rex

On Mon, 2022-02-07 at 12:56 +0800, Rex-BC Chen wrote:
> Since a HS transmission is composed of an arbitrary number
> of bytes that may not be an integer multiple of lanes, some
> lanes may run out of data before others.
> (Defined in 6.1.3 of mipi_DSI_specification_v.01-02-00)
> 
> However, for some DSI RX devices (for example, anx7625),
> there is a limitation that packet number should be the same
> on all DSI lanes. In other words, they need to end a HS at
> the same time.
> 
> Because this limitation is for some specific DSI RX devices,
> it is more reasonable to put the enable control in these
> DSI RX drivers. If DSI TX driver knows the information,
> they can adjust the setting for this situation.
> 
> Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@...iatek.com>
> Acked-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@...el.com>
> ---
>  include/drm/drm_mipi_dsi.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index 147e51b6d241..51e09a1a106a 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -137,6 +137,8 @@ struct mipi_dsi_host
> *of_find_mipi_dsi_host_by_node(struct device_node *node);
>  #define MIPI_DSI_CLOCK_NON_CONTINUOUS	BIT(10)
>  /* transmit data in low power */
>  #define MIPI_DSI_MODE_LPM		BIT(11)
> +/* transmit data ending at the same time for all lanes within one
> hsync */
> +#define MIPI_DSI_HS_PKT_END_ALIGNED	BIT(12)
>  
>  enum mipi_dsi_pixel_format {
>  	MIPI_DSI_FMT_RGB888,