linux-kernel - Re: linux-next: build failure after merge of the spi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 10:07:02 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the spi tree

Às 09:20 de 16/02/22, André Almeida escreveu:
> Hi Stephen,
> 
> Às 02:17 de 16/02/22, Stephen Rothwell escreveu:
>> Hi all,
>>
>> After merging the spi tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>>
>> drivers/spi/spi-amd.c:333:37: error: 'spi_acpi_match' undeclared here (not in a function)
>>   333 |                 .acpi_match_table = spi_acpi_match,
>>       |                                     ^~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>>   209043554915 ("spi: amd: Add support for version AMDI0062")
>>
>> CONFIG_ACPI is not set for this build.
>>
>> I have reverted that commit for today.
>>
> 
> Thanks for input. I'll send a new series with a patch to make this
> driver depends on ACPI then. My patch touched this line, but this
> variable was there before, so I think this build breakage is happening
> for some time.

Actually, the following diff in my commit is the problem:

-		.acpi_match_table = ACPI_PTR(spi_acpi_match),
+		.acpi_match_table = spi_acpi_match,

ACPI_PTR() make it as NULL if CONFIG_ACPI is not set, making the driver
suitable for test compiling even without ACPI enabled. Mark, I'll send a
v3 with this fixed.