linux-kernel - Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2202161625300.11721@cbobk.fhfr.pm>
Date:   Wed, 16 Feb 2022 16:26:00 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Nestor Lopez Casado <nlopezcasad@...itech.com>
cc:     Filipe Laíns <lains@...eup.net>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Lucas Zampieri <lzampier@...hat.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

On Tue, 15 Feb 2022, Nestor Lopez Casado wrote:

> > > > As of logitech lightspeed receiver fw version 04.02.B0009,
> > > > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > > >
> > > > With patch "HID: logitech-dj: add support for the new lightspeed receiver
> > > > iteration", the mouse starts to error out with:
> > > >   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
> > > >   slot 1
> > > > and becomes unusable.
> > > >
> > > > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
> > >
> > > The patch looks good to me.
> > >
> > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> > >
> > > Ideally, Nestor, can you confirm this is expected and that we won't
> > > have any bad surprises there?
> Yes, I confirm this matches our specifications, this is an iteration
> of Lightspeed 1.2
> No objections on my side.

Thanks. Based on this, I've applied this with

	Acked-by: Nestor Lopez Casado <nlopezcasad@...itech.com>

then. Please shout out loudly if you're not ok with that :)

-- 
Jiri Kosina
SUSE Labs