linux-kernel - Re: [PATCH -next] HID: i2c-hid: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Feb 2022 16:30:34 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] HID: i2c-hid: remove unneeded semicolon

On Wed, 16 Feb 2022, Yang Li wrote:

> Eliminate the following coccicheck warning:
> ./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 91b2fa0d33c7..c078f09a2318 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -354,7 +354,7 @@ static int i2c_hid_set_or_send_report(struct i2c_hid *ihid,
>  		 * With simple "send report" all data goes into the output
>  		 * register.
>  		 */
> -		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;;
> +		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;
>  		length += sizeof(__le16);
>  	}

Thanks, that was me fat-fingering the fixup in the original patch. 
Applied.

-- 
Jiri Kosina
SUSE Labs