linux-kernel - Re: [PATCH] pinctrl: ocelot: fix duplicate debugfs entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220216154202.GB14638@MSI.localdomain>
Date:   Wed, 16 Feb 2022 07:42:02 -0800
From:   Colin Foster <colin.foster@...advantage.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: ocelot: fix duplicate debugfs entry

On Wed, Feb 16, 2022 at 01:27:27PM +0100, Michael Walle wrote:
> This driver can have up to two regmaps. If the second one is registered
> its debugfs entry will have the same name as the first one and the
> following error will be printed:
> 
> [    2.242568] debugfs: Directory 'e2004064.pinctrl' with parent 'regmap' already present!
> 
> Give the second regmap a name to avoid this.
> 
> Fixes: 076d9e71bcf8 ("pinctrl: ocelot: convert pinctrl to regmap")
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  drivers/pinctrl/pinctrl-ocelot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index a859fbcb09af..35b213de1af8 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -1890,6 +1890,7 @@ static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
>  		.val_bits = 32,
>  		.reg_stride = 4,
>  		.max_register = 32,
> +		.name = "pincfg",
>  	};
>  
>  	base = devm_platform_ioremap_resource(pdev, 1);
> -- 
> 2.30.2
> 

Reviewed-by: Colin Foster <colin.foster@...advantage.com>