linux-kernel - Re: [PATCH v2 0/3] Magic Keyboard first generation and 2015 FN key mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2202161650050.11721@cbobk.fhfr.pm>
Date:   Wed, 16 Feb 2022 16:50:17 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     José Expósito <jose.exposito89@...il.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Magic Keyboard first generation and 2015 FN key
 mapping

On Tue, 8 Feb 2022, José Expósito wrote:

> Hi everyone,
> 
> This patchset adds the missing key mapping for the Magic Keyboard first
> generation and the 2015 models.
> 
> Since the first generation model had numlock emulation in place, I
> decided to fix the bug (described in the patch) and keep it in place
> just because it has been there for so long that people might use it.
> Having said that, there is no indication in the keyboard about which
> keys can be used as numbers or how to enable/disable numlock.
> I think that a patch removing APPLE_NUMLOCK_EMULATION might make sense,
> but I didn't want to remove existing functionality without asking :)
> 
> Thanks a lot,
> José Expósito
> 
> v2: Resolve conflicts

Queued in hid.git#for-5.18/apple. Thanks José,

-- 
Jiri Kosina
SUSE Labs