linux-kernel - Re: [PATCH net-next 1/9] net: tcp: introduce tcp_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220216075821.219b911f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 16 Feb 2022 07:58:21 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     menglong8.dong@...il.com
Cc:     dsahern@...nel.org, edumazet@...gle.com, davem@...emloft.net,
        rostedt@...dmis.org, mingo@...hat.com, yoshfuji@...ux-ipv6.org,
        ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
        john.fastabend@...il.com, imagedong@...cent.com,
        talalahmad@...gle.com, keescook@...omium.org,
        ilias.apalodimas@...aro.org, alobakin@...me, memxor@...il.com,
        atenart@...nel.org, bigeasy@...utronix.de, pabeni@...hat.com,
        linyunsheng@...wei.com, arnd@...db.de, yajun.deng@...ux.dev,
        roopa@...dia.com, willemb@...gle.com, vvs@...tuozzo.com,
        cong.wang@...edance.com, luiz.von.dentz@...el.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, flyingpeng@...cent.com
Subject: Re: [PATCH net-next 1/9] net: tcp: introduce tcp_drop_reason()

On Wed, 16 Feb 2022 11:54:18 +0800 menglong8.dong@...il.com wrote:
> +static inline void tcp_drop(struct sock *sk, struct sk_buff *skb)
> +{
> +	tcp_drop_reason(sk, skb, SKB_DROP_REASON_NOT_SPECIFIED);
>  }

Please make this non-inline. The compiler will inline it anyway, and 
if it's a static inline compiler will not warn us that it should be
removed once all callers are gone.