linux-kernel - Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa82f347-1b1a-8c40-b5cb-9efe292ae0ec@roeck-us.net>
Date:   Thu, 17 Feb 2022 11:25:28 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     sylv <sylv@...v.io>, Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Patrick Rudolph <patrick.rudolph@...ements.com>,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 2/3] hwmon (xdpe12284): Add support for xdpe11280

On 2/17/22 10:38, sylv wrote:
[ ... ]

>>
>> That makes me wonder if the chip needs to be added to this driver in
>> the first
>> place, or if it could be added to pmbus.c instead. Any idea ?
> 
> Oh, we did wrote a standalone driver too, and it works fine.
> Maybe it's better to upsteam it instead. :)

No, I meant if it would make sense to just add something like

	{"xdpe11280", (kernel_ulong_t)&pmbus_info_one },

to drivers/hwmon/pmbus/pmbus.c.

You only really need a standalone driver if it does something
special, such as a workaround for some register access (like
the xdpe12284 driver), or if support for manufacturer specific
registers is desired or needed. That would, for example, be useful
if the xdpe11280 supports per-phase sensors.

Thanks,
Guenter