linux-kernel - [tip: x86/sgx] selftests/x86: Add validity check and allow field splitting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Feb 2022 20:03:24 -0000
From:   "tip-bot2 for Muhammad Usama Anjum" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     "kernelci.org bot" <bot@...nelci.org>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: x86/sgx] selftests/x86: Add validity check and allow field splitting

The following commit has been merged into the x86/sgx branch of tip:

Commit-ID:     b06e15ebd5bfb670f93c7f11a29b8299c1178bc6
Gitweb:        https://git.kernel.org/tip/b06e15ebd5bfb670f93c7f11a29b8299c1178bc6
Author:        Muhammad Usama Anjum <usama.anjum@...labora.com>
AuthorDate:    Mon, 14 Feb 2022 23:41:08 +05:00
Committer:     Dave Hansen <dave.hansen@...ux.intel.com>
CommitterDate: Thu, 17 Feb 2022 11:55:17 -08:00

selftests/x86: Add validity check and allow field splitting

Add check to test if CC has a string. CC can have multiple sub-strings
like "ccache gcc". Erorr pops up if it is treated as single string and
double quotes are used around it. This can be fixed by removing the
quotes and not treating CC as a single string.

Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection")
Reported-by: "kernelci.org bot" <bot@...nelci.org>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
Link: https://lkml.kernel.org/r/20220214184109.3739179-2-usama.anjum@collabora.com
---
 tools/testing/selftests/x86/check_cc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
index 3e2089c..8c669c0 100755
--- a/tools/testing/selftests/x86/check_cc.sh
+++ b/tools/testing/selftests/x86/check_cc.sh
@@ -7,7 +7,7 @@ CC="$1"
 TESTPROG="$2"
 shift 2
 
-if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
+if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
     echo 1
 else
     echo 0