lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Feb 2022 15:14:14 -0800 From: Stephen Boyd <sboyd@...nel.org> To: Michael Turquette <mturquette@...libre.com>, Taniya Das <tdas@...eaurora.org> Cc: Rajendra Nayak <rnayak@...eaurora.org>, linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, Taniya Das <tdas@...eaurora.org> Subject: Re: [PATCH v2 1/2] clk: qcom: clk-rcg2: Update the calc_rate logic to handle determine rate Quoting Taniya Das (2022-02-02 09:42:12) > In the cases where the RCG parent implements the determine rate ops, the > calc_rate needs to be updated the calculate the rate. I don't follow. Do you mean in cases where 'rate' is close to 32-bits and we're running on a CPU with sizeof(long) == u32? > > Fixes: bcd61c0f535a0 ("clk: qcom: Add support for root clock generators (RCGs)") > Signed-off-by: Taniya Das <tdas@...eaurora.org> > --- > * Split the patch for PLL and RCG. > * Update the Fixes tag. > > drivers/clk/qcom/clk-rcg2.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c > index e1b1b426fae4..2e120a6dd19a 100644 > --- a/drivers/clk/qcom/clk-rcg2.c > +++ b/drivers/clk/qcom/clk-rcg2.c > @@ -147,19 +147,19 @@ static int clk_rcg2_set_parent(struct clk_hw *hw, u8 index) > static unsigned long > calc_rate(unsigned long rate, u32 m, u32 n, u32 mode, u32 hid_div) > { > + u64 tmp = rate; Call it u64 calced_rate or u64 calculated? > + > if (hid_div) { > - rate *= 2; > - rate /= hid_div + 1; > + tmp *= 2; > + do_div(tmp, hid_div + 1); Can this use div_u64()? > } > > if (mode) { > - u64 tmp = rate; > tmp *= m; > do_div(tmp, n); This can probably use div_u64() as well. Do that first in a different patch and then put this patch on top please. > - rate = tmp; > } > > - return rate; > + return tmp; > }
Powered by blists - more mailing lists