linux-kernel - Re: [PATCH 1/3] VMCI: Fix the description of vmci_check_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7844DB64-F8A6-49C2-A0A7-0A9AA634BFDA@vmware.com>
Date:   Thu, 17 Feb 2022 07:08:57 +0000
From:   Vishnu Dasa <vdasa@...are.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     Jorgen Hansen <jhansen@...are.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "acking@...are.com" <acking@...are.com>,
        "dtor@...are.com" <dtor@...are.com>,
        Pv-drivers <Pv-drivers@...are.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps()


> On Feb 10, 2022, at 2:27 PM, Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:
> 
> vmci_check_host_caps() doesn't return a bool but an int.
> Fix the description accordingly.
> 
> Fixes: 	782f24453536 ("VMCI: fix error handling path when registering guest driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> drivers/misc/vmw_vmci/vmci_guest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index aa61a687b3e2..1a1858742f75 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -253,9 +253,9 @@ static void vmci_guest_cid_update(u32 sub_id,
> 
> /*
>  * Verify that the host supports the hypercalls we need. If it does not,
> - * try to find fallback hypercalls and use those instead.  Returns
> - * true if required hypercalls (or fallback hypercalls) are
> - * supported by the host, false otherwise.
> + * try to find fallback hypercalls and use those instead.  Returns 0 if
> + * required hypercalls (or fallback hypercalls) are supported by the host,
> + * an error code otherwise.
>  */
> static int vmci_check_host_caps(struct pci_dev *pdev)
> {
> -- 
> 2.32.0
> 

Thanks!

Acked-by: Vishnu Dasa <vdasa@...are.com>