linux-kernel - Re: [PATCH -next] kernel/fork: Remove duplicated include in kernel/fork.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANpmjNNhbdr6gsQ-za=7mUH2etXqQ3voWncd2mg3fcdiEWWnnQ@mail.gmail.com>
Date:   Thu, 17 Feb 2022 09:34:06 +0100
From:   Marco Elver <elver@...gle.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     akpm@...ux-foundation.org, ebiederm@...ssion.com, eb@...ix.com,
        linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>,
        Borislav Petkov <bp@...e.de>, fenghua.yu@...el.com
Subject: Re: [PATCH -next] kernel/fork: Remove duplicated include in kernel/fork.c

On Thu, 17 Feb 2022 at 01:42, Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> Fix following includecheck warning:
> ./kernel/fork.c: linux/sched/mm.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

This looks like a reasonable fix -- but why is this "To" me? At the
very least you'd have to get the email of the original author that
added that line and perhaps the committer. Cc'd the right people.

Looks like another robot sent the exact same fix:
https://lore.kernel.org/all/20220217015348.1900270-1-deng.changcheng@zte.com.cn/

Too many robots sending the same things will be interesting...

> ---
>  kernel/fork.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 64dbfb9426fd..2bfc74c2d2e3 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -97,7 +97,6 @@
>  #include <linux/scs.h>
>  #include <linux/io_uring.h>
>  #include <linux/bpf.h>
> -#include <linux/sched/mm.h>
>
>  #include <asm/pgalloc.h>
>  #include <linux/uaccess.h>
> --
> 2.20.1.7.g153144c
>