lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 17 Feb 2022 00:51:40 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     "Wang Jianchao (Kuaishou)" <jianchao.wan9@...il.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Josef Bacik <jbacik@...com>,
        Tejun Heo <tj@...nel.org>,
        Bart Van Assche <bvanassche@....org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC V4 3/6] blk-iolatency: make iolatency pluggable

> +static inline struct rq_qos *blkcg_rq_qos(struct request_queue *q)
> +{
> +	return rq_qos_by_id(q, blkcg_iolatency_ops.id);
> +}

This just has a single user, so open code it.

> +static int blk_iolatency_init(struct request_queue *q);
> +
>  static struct rq_qos_ops blkcg_iolatency_ops = {
> +	.name = "blk-iolat",
> +	.flags = RQOS_FLAG_CGRP_POL,
>  	.throttle = blkcg_iolatency_throttle,
>  	.done_bio = blkcg_iolatency_done_bio,
>  	.exit = blkcg_iolatency_exit,
> +	.init = blk_iolatency_init,
>  };

I'd move this structure below blk_iolatency_init to avoid the forward
declaration of blk_iolatency_init

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ