lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Feb 2022 12:47:32 +0100 From: Lukas Wunner <lukas@...ner.de> To: Lino Sanfilippo <LinoSanfilippo@....de> Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, u.kleine-koenig@...gutronix.de, linux@...linux.org.uk, richard.genoud@...il.com, nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com, ludovic.desroches@...rochip.com, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, linux-imx@....com, mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com, linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com Subject: Re: [PATCH 2 4/9] serial: sc16is7xx: remove redundant check in rs485_config On Wed, Feb 16, 2022 at 01:17:58AM +0100, Lino Sanfilippo wrote: > --- a/drivers/tty/serial/sc16is7xx.c > +++ b/drivers/tty/serial/sc16is7xx.c > @@ -959,16 +959,6 @@ static int sc16is7xx_config_rs485(struct uart_port *port, > struct sc16is7xx_one *one = to_sc16is7xx_one(port, port); > > if (rs485->flags & SER_RS485_ENABLED) { > - bool rts_during_rx, rts_during_tx; > - > - rts_during_rx = rs485->flags & SER_RS485_RTS_AFTER_SEND; > - rts_during_tx = rs485->flags & SER_RS485_RTS_ON_SEND; > - > - if (rts_during_rx == rts_during_tx) > - dev_err(port->dev, > - "unsupported RTS signalling on_send:%d after_send:%d - exactly one of RS485 RTS flags should be set\n", > - rts_during_tx, rts_during_rx); > - Hm, patch 1 in this series doesn't emit such a message, so unlike now, users will no longer be warned that they passed in nonsensical settings...
Powered by blists - more mailing lists