linux-kernel - Re: [PATCH net-next] net: hns3: Remove unused inline function hclge_is_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171c12cc-5b05-a567-59cf-66e211aba941@huawei.com>
Date:   Thu, 17 Feb 2022 10:25:33 +0800
From:   "wangjie (L)" <wangjie125@...wei.com>
To:     YueHaibing <yuehaibing@...wei.com>, <yisen.zhuang@...wei.com>,
        <salil.mehta@...wei.com>, <davem@...emloft.net>, <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: hns3: Remove unused inline function
 hclge_is_reset_pending()

Reviewed-by: Jie Wang <wangjie125@...wei.com>

On 2022/2/16 19:35, YueHaibing wrote:
> This is unused since commit 8e2288cad6cb ("net: hns3: refactor PF
> cmdq init and uninit APIs with new common APIs").
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
> index adfb26e79262..3c5e76eaf90b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h
> @@ -1060,11 +1060,6 @@ static inline int hclge_get_queue_id(struct hnae3_queue *queue)
>  	return tqp->index;
>  }
>
> -static inline bool hclge_is_reset_pending(struct hclge_dev *hdev)
> -{
> -	return !!hdev->reset_pending;
> -}
> -
>  int hclge_inform_reset_assert_to_vf(struct hclge_vport *vport);
>  int hclge_cfg_mac_speed_dup(struct hclge_dev *hdev, int speed, u8 duplex);
>  int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto,
>