[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <33bd6122-b4aa-1659-6063-95175a8748b3@arm.com>
Date: Thu, 17 Feb 2022 12:37:11 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Linux PM <linux-pm@...r.kernel.org>,
amit daniel kachhap <amit.kachhap@...il.com>,
Viresh Kumar <viresh.kumar@...aro.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Pierre.Gondois@....com, Stephen Boyd <swboyd@...omium.org>,
Rajendra Nayak <rnayak@...eaurora.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Doug Anderson <dianders@...omium.org>,
Matthias Kaehlcke <mka@...omium.org>,
Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in
cpufreq_cooling and devfreq_cooling
On 2/17/22 12:33 PM, Daniel Lezcano wrote:
> On 17/02/2022 13:11, Lukasz Luba wrote:
>
> [ ... ]
>
>>> Why not make it more generic and replace the frequency by a
>>> performance index, so it can be used by any kind of perf limiter?
>>
>> For that DT array, yes, it can be an index, so effectively it could be
>> a simple 1d array.
>>
>> something like:
>>
>> msm_gpu_energy_model: msm-gpu-energy-model {
>> compatible = "energy-model"
>> /* Values are sorted micro-Watts which correspond to each OPP
>> or performance state. The total amount of them must match
>> number of OPPs. */
>> power-microwatt = <100000>,
>> <230000>,
>> <380000>,
>> <600000>;
>> };
>>
>> then in gpu node instead of having 'dynamic-power-coefficient',
>> which is useless because voltage is missing, we would have
>> 'energy-model', like:
>>
>> energy-model = <&msm_gpu_energy_model>;
>>
>>
>> If you agree to continue this topic. I will send an RFC so we could
>> further discuss this idea. This $subject doesn't fit well.
>
> Yes, definitively I agree to continue on this topic.
>
>
Great! I'm going to craft something...
Powered by blists - more mailing lists