linux-kernel - Re: [PATCH v2 02/15] staging: r8188eu: remove smaller sets of converted DBG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Feb 2022 17:36:31 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org,
        Larry.Finger@...inger.net, straube.linux@...il.com,
        martin@...ser.cx, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/15] staging: r8188eu: remove smaller sets of
 converted DBG_88E calls

On Wed, Feb 16, 2022 at 12:42:57PM +0300, Pavel Skripkin wrote:
> > @@ -1467,15 +1447,6 @@ static int rtw_check_join_candidate(struct mlme_priv *pmlmepriv
> >   		updated = true;
> >   	}
> >   	if (updated) {
> > -		netdev_dbg(adapter->pnetdev,
> > -			   "[by_bssid:%u][assoc_ssid:%s]new candidate: %s(%pM rssi:%d\n",
> > -			   pmlmepriv->assoc_by_bssid,
> > -			   pmlmepriv->assoc_ssid.Ssid,
> > -			   (*candidate)->network.Ssid.Ssid,
> > -			   (*candidate)->network.MacAddress,
> > -			   (int)(*candidate)->network.Rssi);
> > -		netdev_dbg(adapter->pnetdev,
> > -			   "[to_roaming:%u]\n", rtw_to_roaming(adapter));
> >   	}
> 
> drop if

Yeah.  If you can drop the whole if statement then let's do that.

regards,
dan carpenter