lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Feb 2022 23:29:06 +0800 From: xkernel.wang@...mail.com To: jerome.pouiller@...abs.com, gregkh@...uxfoundation.org Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, Xiaoke Wang <xkernel.wang@...mail.com> Subject: [PATCH] staging: wfx: fix the error handling in wfx_init_common() From: Xiaoke Wang <xkernel.wang@...mail.com> All the error handlers of wfx_init_common() return without calling ieee80211_free_hw(hw), which may result in memory leak. So I add one err label to unify the error handlers. Suggested-by: Jérôme Pouiller <jerome.pouiller@...abs.com> Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com> --- drivers/staging/wfx/main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index 4b9fdf9..f83df9f 100644 --- a/drivers/staging/wfx/main.c +++ b/drivers/staging/wfx/main.c @@ -309,7 +309,8 @@ struct wfx_dev *wfx_init_common(struct device *dev, wdev->pdata.gpio_wakeup = devm_gpiod_get_optional(dev, "wakeup", GPIOD_OUT_LOW); if (IS_ERR(wdev->pdata.gpio_wakeup)) - return NULL; + goto err; + if (wdev->pdata.gpio_wakeup) gpiod_set_consumer_name(wdev->pdata.gpio_wakeup, "wfx wakeup"); @@ -325,9 +326,13 @@ struct wfx_dev *wfx_init_common(struct device *dev, wdev->force_ps_timeout = -1; if (devm_add_action_or_reset(dev, wfx_free_common, wdev)) - return NULL; + goto err; return wdev; + +err: + ieee80211_free_hw(hw); + return NULL; } int wfx_probe(struct wfx_dev *wdev) --
Powered by blists - more mailing lists