[<prev] [next>] [day] [month] [year] [list]
Message-ID: <tencent_03873F2A51FFDF808C33B3E73A717C51400A@qq.com>
Date: Thu, 17 Feb 2022 23:47:22 +0800
From: xkernel.wang@...mail.com
To: jerome.pouiller@...abs.com, gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
Xiaoke Wang <xkernel.wang@...mail.com>
Subject: [PATCH 2/2] staging: wfx: check the return value of devm_kmalloc()
From: Xiaoke Wang <xkernel.wang@...mail.com>
devm_kmalloc() returns a pointer to allocated memory on success, NULL
on failure. While there is a memory allocation of devm_kmalloc()
without proper check. It is better to check the return value of it to
prevent wrong memory access.
Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>
---
drivers/staging/wfx/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index f83df9f..5d4fcc3 100644
--- a/drivers/staging/wfx/main.c
+++ b/drivers/staging/wfx/main.c
@@ -294,6 +294,9 @@ struct wfx_dev *wfx_init_common(struct device *dev,
hw->wiphy->n_iface_combinations = ARRAY_SIZE(wfx_iface_combinations);
hw->wiphy->iface_combinations = wfx_iface_combinations;
hw->wiphy->bands[NL80211_BAND_2GHZ] = devm_kmalloc(dev, sizeof(wfx_band_2ghz), GFP_KERNEL);
+ if (!hw->wiphy->bands[NL80211_BAND_2GHZ])
+ goto err;
+
// FIXME: also copy wfx_rates and wfx_2ghz_chantable
memcpy(hw->wiphy->bands[NL80211_BAND_2GHZ], &wfx_band_2ghz,
sizeof(wfx_band_2ghz));
--
Powered by blists - more mailing lists