linux-kernel - Re: [PATCH v5 13/13] module: Move version support into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2202171648590.29121@pobox.suse.cz>
Date:   Thu, 17 Feb 2022 16:51:04 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Aaron Tomlin <atomlin@...hat.com>
cc:     Christophe Leroy <christophe.leroy@...roup.eu>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "cl@...ux.com" <cl@...ux.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "jeyu@...nel.org" <jeyu@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "live-patching@...r.kernel.org" <live-patching@...r.kernel.org>,
        "atomlin@...mlin.com" <atomlin@...mlin.com>,
        "ghalat@...hat.com" <ghalat@...hat.com>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>,
        "void@...ifault.com" <void@...ifault.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "msuchanek@...e.de" <msuchanek@...e.de>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>
Subject: Re: [PATCH v5 13/13] module: Move version support into a separate
 file

> > > +struct symsearch {
> > > +    const struct kernel_symbol *start, *stop;
> > > +    const s32 *crcs;
> > > +    enum mod_license {
> > > +        NOT_GPL_ONLY,
> > > +        GPL_ONLY,
> > > +    } license;
> > > +};
> >
> > Why don't leave this in main.c ?
> 
> Yes, struct 'symsearch' is not used outside of kernel/module/main.c.

It is not, but "struct find_symbol_arg", which you moved, uses "enum 
mod_license" defined above, so you can either leave it as it is, or carve 
"enum mod_license" definition out.

Miroslav