linux-kernel - Re: [RFC V2 17/21] watchdog/dev: Add tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba924008-c0ab-4800-aac4-d9d9ae930c32@kernel.org>
Date:   Thu, 17 Feb 2022 17:27:09 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     "Peter.Enderborg@...y.com" <Peter.Enderborg@...y.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Marco Elver <elver@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Gabriele Paoloni <gpaoloni@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-trace-devel@...r.kernel.org" 
        <linux-trace-devel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RFC V2 17/21] watchdog/dev: Add tracepoints

Hi Peter

On 2/16/22 17:01, Peter.Enderborg@...y.com wrote:
> On 2/14/22 11:45, Daniel Bristot de Oliveira wrote:
>> Add a set of tracepoints, enabling the observability of the watchdog
>> device interactions with user-space.
>>
>> The events are:
>> 	watchdog:watchdog_open
>> 	watchdog:watchdog_close
>> 	watchdog:watchdog_start
>> 	watchdog:watchdog_stop
>> 	watchdog:watchdog_set_timeout
>> 	watchdog:watchdog_ping
>> 	watchdog:watchdog_nowayout
>> 	watchdog:watchdog_set_keep_alive
>> 	watchdog:watchdog_keep_alive
> 
> Some watchdogs have a bark functionality, I think it should be event for that too.
> 

I understand. The problems is that I do not see the bark abstraction in the
watchdog_dev layer.

In the case I am investigating (the safety_monitor/safety_app) the bark is
outside of the "OS" view, it is an hardware action - like. shutdown.

Am I missing something? Thoughts?

-- Daniel