linux-kernel - Re: [PATCH v2 03/18] KVM: x86/mmu: WARN if PAE roots linger after kvm_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db3e3781-0ae8-7392-b899-b386f4df0368@redhat.com>
Date:   Fri, 18 Feb 2022 18:23:24 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v2 03/18] KVM: x86/mmu: WARN if PAE roots linger after
 kvm_mmu_unload

On 2/18/22 18:14, Sean Christopherson wrote:
> Checkpatch doesn't like it, and IMO the existing asserts
> are unnecessary.

I agree that removing the assertions could be another way to go.

A third and better one could be to just wait until pae_root is gone.  I 
have started looking at it but I would like your opinion on one detail; 
see question I posted at 
https://lore.kernel.org/kvm/7ccb16e5-579e-b3d9-cedc-305152ef9b8f@redhat.com/.

For now I'll drop this patch.

Paolo