linux-kernel - Re: [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220218142301.0b5731e1@gandalf.local.home>
Date:   Fri, 18 Feb 2022 14:23:01 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Jakub Matěna <matenajakub@...il.com>,
        linux-mm@...ck.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, vbabka@...e.cz, mhocko@...nel.org,
        mgorman@...hsingularity.net, liam.howlett@...cle.com,
        hughd@...gle.com, kirill@...temov.name, riel@...riel.com,
        peterz@...radead.org
Subject: Re: [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges

On Fri, 18 Feb 2022 18:46:29 +0000
Matthew Wilcox <willy@...radead.org> wrote:

> On Fri, Feb 18, 2022 at 01:09:20PM -0500, Steven Rostedt wrote:
> > Please indent the above better. That is:
> > 
> > 		__entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT)
> > 				+ (merge_next == AV_MERGE_DIFFERENT)
> > 				+ (merge_both == AV_MERGE_DIFFERENT);  
> 
> I thought our coding style preferred trailing operators; that is:
> 
> 		 __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) +
> 				(merge_next == AV_MERGE_DIFFERENT) +
> 				(merge_both == AV_MERGE_DIFFERENT);

I'm OK with either. I just can't handle the original.

-- Steve