linux-kernel - Re: [PATCH v3] net: fix wrong network header length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220218022315.2560-1-lina.wang@mediatek.com>
Date:   Fri, 18 Feb 2022 10:23:15 +0800
From:   Lina Wang <lina.wang@...iatek.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        bpf <bpf@...r.kernel.org>,
        Maciej Żenczykowski <maze@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH v3] net: fix wrong network header length

On Thu, 2022-02-17 at 09:05 -0800, Alexei Starovoitov wrote:
> On Thu, Feb 17, 2022 at 12:45 AM Paolo Abeni <pabeni@...hat.com>
> wrote:
> > To clarify: Alexei is asking to add a test under:
> > 
> > tools/testing/selftests/net/
> > 
> > to cover this specific case. You can propbably extend the existing
> > udpgro_fwd.sh.
> 
> Exactly.
> I suspect the setup needs a bit more than just iperf udp test.
> Does it need a specific driver and hw?

My hw is Android phone, Android system has improved clatd with bpf. When 
clatd starts, cls_bpf_classify will handle ingress packets with bpf progs.
bpf_skb_proto_6_to_4 is used here.

> Can it be reproduced with veth or other virtual netdev?

I am not sure. I have no idea how to verify it in linux system. 

> Also commit talks about bpf_skb_proto_6_to_4.
> So that bpf helper has to be somehow involved, but iperf udp test
> says nothing about it.
> Please craft a _complete_ selftest.

Thanks!