linux-kernel - Re: [PATCH v2] input: Add Marine Navigation Keycodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a34020c-008e-834b-f341-4ea03b83e31c@garmin.com>
Date:   Fri, 18 Feb 2022 14:53:32 -0600
From:   Shelby Heffron <Shelby.Heffron@...min.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] input: Add Marine Navigation Keycodes

Hi Dmitry,

>> +/* Toggle the focus in or out */
>> +#define KEY_FOCUS_TOGGLE            0x27b
>
> Could it be served by KEY_SELECT?

We have found another keycode that will serve for this. Will remove in
next patch.

>> +
>> +/* Move between highlightable items */
>> +#define KEY_NEXT_HIGHLIGHT          0x27c
>> +#define KEY_PREVIOUS_HIGHLIGHT              0x27d
>
> I wonder if KEY_NEXT and KEY_PREVIOUS would be suitable for your
> application.

Yes, those keycodes should be suitable. Will remove in next patch.

>> +/* Navigate Displays */
>> +#define KEY_NEXT_DISPLAY            0x27f
>> +#define KEY_PREVIOUS_DISPLAY                0x280
>
> I am not familiar with marine navigation devices, could you please
> explain a bit more about displays you are navigating. Are there separate
> physical screens or are there several application screens/views you are
> switching between?
>

Yes - these keys would navigate between separate physical screens.

>> +#define KEY_BRIGHTNESS_MENU         0x28c
>
> Do you have multiple menus in the application?
>
We have found another keycode that will serve for this. Will remove in
next patch.

Thanks.
Shelby

________________________________

CONFIDENTIALITY NOTICE: This email and any attachments are for the sole use of the intended recipient(s) and contain information that may be Garmin confidential and/or Garmin legally privileged. If you have received this email in error, please notify the sender by reply email and delete the message. Any disclosure, copying, distribution or use of this communication (including attachments) by someone other than the intended recipient is prohibited. Thank you.