linux-kernel - Re: v5.17-rc3 compile failure on aarch64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F85853B6-A81C-4AD9-972C-747CAD6391B8@fb.com>
Date:   Fri, 18 Feb 2022 23:10:51 +0000
From:   Nick Terrell <terrelln@...com>
To:     Qu Wenruo <quwenruo.btrfs@....com>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: v5.17-rc3 compile failure on aarch64


> On Feb 17, 2022, at 12:37 AM, Qu Wenruo <quwenruo.btrfs@....com> wrote:
> 
> Hi,
> 
> Recently I found v5.17-rc3 kernel failed to compile on my aarch64 setup,
> it failed with the following error messages:
> 
>  AR      lib/zstd/built-in.a
>  LD [M]  lib/zstd/zstd_compress.o
> ld: __patchable_function_entries has both ordered
> [`__patchable_function_entries' in lib/zstd/common/entropy_common.o] and
> unordered [`__patchable_function_entries' in
> lib/zstd/common/error_private.o] sections
> ld: final link failed: bad value
> make[2]: *** [scripts/Makefile.build:484: lib/zstd/zstd_compress.o] Error 1
> make[1]: *** [scripts/Makefile.build:550: lib/zstd] Error 2
> make: *** [Makefile:1831: lib] Error 2
> make: *** Waiting for unfinished jobs....

I'm not sure what's going on, but maybe I can provide a hint to people
more knowledgable about the situation.

These objects are included in both the `zstd_compress` and
`zstd_decompress` modules [0]. That may be relevant. Back in 2018
we used to avoid having duplicate objects in different modules,
but then kbuild added support for it, and it was cleaned up in commit
dc35da16 [1].

It also may be irrelevant. Zstd was updated in the v5.16 kernel, but hasn't
changed in the v5.17 kernel.

Best,
Nick Terrell

[0] https://github.com/torvalds/linux/blob/master/lib/zstd/Makefile
[1] https://github.com/torvalds/linux/commit/dc35da16a2e23db04822f0129cd5b28b7b0e72b4

> But the same code base compiles fine inside my x86_64 VM.
> 
> The aarch64 environment is an VM running on RockPro64 or RPI CM4.
> 
> With a little older gcc (v10.2.0) and bintuils (2.35).
> 
> While for my x86_64 VM it has newer gcc (11.1.0) and binutiles (2.36.1)
> 
> I'm super happy to upgrade my tool chain for my aarch64 VM, but I'm a
> little concerned if there is something worthy fixed.
> 
> Thanks,
> Qu