linux-kernel - Re: [RFC V4 2/6] blk-wbt: make wbt pluggable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Feb 2022 11:41:11 +0800
From:   Wang Jianchao <jianchao.wan9@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jens Axboe <axboe@...nel.dk>, Josef Bacik <jbacik@...com>,
        Tejun Heo <tj@...nel.org>,
        Bart Van Assche <bvanassche@....org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC V4 2/6] blk-wbt: make wbt pluggable



On 2022/2/17 4:50 下午, Christoph Hellwig wrote:
>> +struct rq_qos *wbt_rq_qos(struct request_queue *q);
>>  int wbt_init(struct request_queue *);
> 
> 
> Please move the wb_lat sysfs attribute into blk-wbt.c as well, which
> removes the need to expose these two functions.
> 

Given this patchset:
(1) Do we need to reserve the wb_lat sysfs when we turn off the wbt ?
(2) Do we need to disable wbt automatically when switch io scheduler
    to bfq ? Or just tell the user turn off the wbt by themselves ?

Thanks
Jianchao