linux-kernel - Re: [PATCH] HID: Add mapping for KEY_APP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yg9BN1wU87t5ddoC@google.com>
Date:   Thu, 17 Feb 2022 22:48:23 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     William Mahon <wmahon@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        William Mahon <wmahon@...gle.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: Add mapping for KEY_APP_LAUNCHER

On Thu, Feb 17, 2022 at 11:35:24AM +0100, Bastien Nocera wrote:
> On Thu, 2022-02-17 at 05:33 +0000, William Mahon wrote:
> > The App Launcher key is used to bring up the Launcher menu.
> > 
> > This patch adds a new key definition KEY_APP_LAUNCHER and maps
> > 0x0c02a28
>  
> Is this a typo? It's not the same format as in your other patch.
> 
> KEY_DASHBOARD as used in the Mac keyboard drivers looks like a good
> match for KEY_APP_LAUNCHER. If not, it would be good to explain why in
> the commit message.
> 
> See 437184ae8bd1ef923a40b009e37801deae66ad55 for the KEY_DASHBOARD
> addition.

I agree that the spirit of KEY_DASHBOARD is what I think we want here,
but IMO neither KEY_DASHBOARD nor KEY_APP_LAUNCHER are good names for
this. Maybe we could use KEY_ALL_APPLICATIONS (and alias
KEY_KEY_DASHBOARD to it for compatibility)?

Thanks.

-- 
Dmitry