linux-kernel - Re: [PATCH] clk: qcom: ipq8074: Use floor ops for SDCC1 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220218001439.57B6FC340E8@smtp.kernel.org>
Date:   Thu, 17 Feb 2022 16:14:36 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Robert Marko <robimarko@...il.com>, absahu@...eaurora.org,
        agross@...nel.org, bjorn.andersson@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com
Cc:     Dirk Buchwalder <buchwalder@...teo.de>,
        Robert Marko <robimarko@...il.com>
Subject: Re: [PATCH] clk: qcom: ipq8074: Use floor ops for SDCC1 clock

Quoting Robert Marko (2022-02-10 09:31:00)
> From: Dirk Buchwalder <buchwalder@...teo.de>
> 
> Use floor ops on SDCC1 APPS clock in order to round down selected clock
> frequency and avoid overclocking SD/eMMC cards.
> 
> For example, currently HS200 cards were failling tuning as they were
> actually being clocked at 384MHz instead of 192MHz.
> This caused some boards to disable 1.8V I/O and force the eMMC into the
> standard HS mode (50MHz) and that appeared to work despite the eMMC being
> overclocked to 96Mhz in that case.
> 
> There was a previous commit to use floor ops on SDCC clocks, but it looks
> to have only covered SDCC2 clock.
> 
> Fixes: 9607f6224b39 ("clk: qcom: ipq8074: add PCIE, USB and SDCC clocks")
> 
> Signed-off-by: Dirk Buchwalder <buchwalder@...teo.de>
> Signed-off-by: Robert Marko <robimarko@...il.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>