linux-kernel - RE: [Intel-wired-lan] [PATCH net-next 1/2] i40e: remove dead stores on XSK hotpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5144743C1D59676DB4E234B3E2379@PH0PR11MB5144.namprd11.prod.outlook.com>
Date:   Fri, 18 Feb 2022 08:35:52 +0000
From:   "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jesper Dangaard Brouer" <hawk@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "Alexei Starovoitov" <ast@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "Dumitrescu, Cristian" <cristian.dumitrescu@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Nagraj, Shravan" <shravan.nagraj@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next 1/2] i40e: remove dead stores
 on XSK hotpath

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Lobakin,
> Alexandr
> Sent: Wednesday, December 1, 2021 12:07 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: linux-kernel@...r.kernel.org; Jesper Dangaard Brouer <hawk@...nel.org>;
> Daniel Borkmann <daniel@...earbox.net>; netdev@...r.kernel.org;
> bpf@...r.kernel.org; John Fastabend <john.fastabend@...il.com>; Alexei
> Starovoitov <ast@...nel.org>; Jakub Kicinski <kuba@...nel.org>; Dumitrescu,
> Cristian <cristian.dumitrescu@...el.com>; David S. Miller <davem@...emloft.net>;
> Karlsson, Magnus <magnus.karlsson@...el.com>
> Subject: [Intel-wired-lan] [PATCH net-next 1/2] i40e: remove dead stores on XSK
> hotpath
> 
> The 'if (ntu == rx_ring->count)' block in i40e_alloc_rx_buffers_zc() was previously
> residing in the loop, but after introducing the batched interface it is used only to wrap-
> around the NTU descriptor, thus no more need to assign 'xdp'.
> 
> 'cleaned_count' in i40e_clean_rx_irq_zc() was previously being incremented in the
> loop, but after commit f12738b6ec06
> ("i40e: remove unnecessary cleaned_count updates") it gets assigned only once after
> it, so the initialization can be dropped.
> 
> Fixes: 6aab0bb0c5cd ("i40e: Use the xsk batched rx allocation interface")
> Fixes: f12738b6ec06 ("i40e: remove unnecessary cleaned_count updates")
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@...el.com>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@...el.com>