linux-kernel - Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2535719.D4RZWD7AcY@pc-42>
Date:   Fri, 18 Feb 2022 11:57:47 +0100
From:   Jérôme Pouiller <jerome.pouiller@...abs.com>
To:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Kalle Valo <kvalo@...eaurora.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        Riccardo Ferrazzo <rferrazzo@...e.com>
Subject: Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote:
> From: Riccardo Ferrazzo <rferrazzo@...e.com>
> 
> Some variants of the WF200 disallow active scan on channel 12 and 13.
> For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR.
> 
> However, the beacon hint procedure was removing the flag
> IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was
> making subsequent scans to fail because the driver was trying active
> scans on prohibited channels.
> 
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

I forgot to mention I have reviewed on this patch:

Reviewed-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

> ---
>  drivers/staging/wfx/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
> index d832a22850c7..5999e81dc44d 100644
> --- a/drivers/staging/wfx/main.c
> +++ b/drivers/staging/wfx/main.c
> @@ -381,6 +381,7 @@ int wfx_probe(struct wfx_dev *wdev)
>  	}
>  
>  	if (wdev->hw_caps.region_sel_mode) {
> +		wdev->hw->wiphy->regulatory_flags |= REGULATORY_DISABLE_BEACON_HINTS;
>  		wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]->channels[11].flags |=
>  			IEEE80211_CHAN_NO_IR;
>  		wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]->channels[12].flags |=
> 


-- 
Jérôme Pouiller