linux-kernel - Re: [PATCH 1/2] net/fsl: fman: Allow fm_max_frame_sz & rx_extra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEDiaShTrWgA75e8x2deHMHF-53LFiusrVHTxP_Jy4gvaLg_9A@mail.gmail.com>
Date:   Fri, 18 Feb 2022 12:28:57 +0100
From:   EVS Hardware Dpt <hardware.evs@...il.com>
To:     Madalin Bucur <madalin.bucur@....com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] net/fsl: fman: Allow fm_max_frame_sz &
 rx_extra_headroom config from devicetree.

Hi Madalin, Guys

I know, but it's somewhat difficult to use those parameters on kernel's
command line.
I don't think it's wrong to also add that in devicetree.
No removal, just an added feature.

For ethernet node in devicetree, there are a lot of configuration stuff like
max-frame-size to allow configuration of MTU
(and so potentially enable jumbo) and it's regarded as fine.

It's also the goal of this patch. Allow an easy configuration of
fsl_fm_max_frm from a dts. I added rx_extra_headroom for the sake of
completeness.

So I plead for this addition because I don't think it's wrong to do that and
I consider it's nicer to add an optional devicetree property rather than
adding a lot of obscure stuff on kernel's command line.

Hope you'll share my point of view.

Have a nice weekend Madalin, Guys,
Fred.

Le ven. 18 févr. 2022 à 08:23, Madalin Bucur <madalin.bucur@....com> a écrit :
>
> > -----Original Message-----
> > From: Fred Lefranc <hardware.evs@...il.com>
> > Subject: [PATCH 1/2] net/fsl: fman: Allow fm_max_frame_sz &
> > rx_extra_headroom config from devicetree.
> >
> > Allow modification of two additional Frame Manager parameters :
> > - FM Max Frame Size : Can be changed to a value other than 1522
> >   (ie support Jumbo Frames)
> > - RX Extra Headroom
> >
> > Signed-off-by: Fred Lefranc <hardware.evs@...il.com>
>
> Hi, Fred,
>
> there are module params already for both, look into
>
> drivers/net/ethernet/freescale/fman/fman.c
>
> for fsl_fm_rx_extra_headroom and fsl_fm_max_frm.
>
> Regards,
> Madalin