linux-kernel - Re: [PATCH V3 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yg7ZDoH1HBkOZvIH@robh.at.kernel.org>
Date:   Thu, 17 Feb 2022 17:23:58 -0600
From:   Rob Herring <robh@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     jassisinghbrar@...il.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        krzysztof.kozlowski@...onical.com, daniel.baluta@....com,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V3 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU
 support

On Fri, Feb 11, 2022 at 02:02:58PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication
> between Sentinel and Cortex-A cores from hardware design, it could not be
> reused for other purpose.
> 
> However i.MX93 S4 MU use separate tx/rx interrupt, so update
> interrupts and add interrupt-names property.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  .../devicetree/bindings/mailbox/fsl,mu.yaml   | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> index 6d056d5e16bf..f0a7e693ebf8 100644
> --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> @@ -29,6 +29,7 @@ properties:
>        - const: fsl,imx8ulp-mu
>        - const: fsl,imx8-mu-scu
>        - const: fsl,imx8-mu-seco
> +      - const: fsl,imx93-mu-s4
>        - const: fsl,imx8ulp-mu-s4
>        - items:
>            - const: fsl,imx93-mu
> @@ -57,6 +58,12 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - const: txirq
> +      - const: rxirq

'irq' is redundant. Drop.

> +
>    "#mbox-cells":
>      description: |
>        <&phandle type channel>
> @@ -90,6 +97,20 @@ required:
>    - interrupts
>    - "#mbox-cells"
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - fsl,imx93-mu-s4
> +    then:
> +      properties:
> +        interrupt-names:
> +          minItems: 2
> +          maxItems: 2

minItems is enough.

> +        interrupts:
> +          maxItems: 2

You haven't tested this with 2 items. It will fail because the main 
section has a limit of 1 item.

Rob