[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3a36a973-1bc2-0472-9820-375584e00982@canonical.com>
Date: Fri, 18 Feb 2022 12:36:30 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: Raveendra Padasalagi <raveendra.padasalagi@...adcom.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc: bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v3 1/2] Documentation: dt: extcon: add optional
input-debounce attribute
On 18/02/2022 12:32, Krzysztof Kozlowski wrote:
> On 19/10/2017 11:52, Raveendra Padasalagi wrote:
>> Add documentation on optional dt attribute "input-debounce"
>> in extcon node to capture user specified timeout value for id
>> and vbus gpio detection.
>>
>> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@...adcom.com>
>> Reviewed-by: Ray Jui <ray.jui@...adcom.com>
>> Reviewed-by: Srinath Mannam <srinath.mannam@...adcom.com>
>> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
>> ---
>>
>> Changes in v3:
>> - Modified commit log to name debounce-timeout-ms to input-debounce
>> - Added Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
>>
>> Changes in v2:
>> Rename debounce-timeout-ms to input-debounce
>>
>> Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> index dfc14f7..d115900 100644
>> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
>> - id-gpio: gpio for USB ID pin. See gpio binding.
>> - vbus-gpio: gpio for USB VBUS pin.
>>
>> +Optional properties:
>> +- input-debounce: debounce timeout value for id and vbus gpio in microseconds.
>> +
>
> Use standard unit suffix. See schemas/property-units.yaml in dtschema
> sources/repo.
Although different topic is what Rob expressed here:
https://lore.kernel.org/all/20171025145337.kubcbkxrhbsy6o4a@rob-hp-laptop/
It's a no go and sending new versions is not the way to deal with it.
Best regards,
Krzysztof
Powered by blists - more mailing lists