linux-kernel - Re: [PATCH v2 16/18] ARM: dts: qcom: remove redundant binding from ipq8064 rb3011 dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yg+pL44ogVscn9Kw@earth.li>
Date:   Fri, 18 Feb 2022 14:11:59 +0000
From:   Jonathan McDowell <noodles@...th.li>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 16/18] ARM: dts: qcom: remove redundant binding from
 ipq8064 rb3011 dts

On Fri, Feb 18, 2022 at 01:29:54AM +0100, Ansuel Smith wrote:
> Mdio0_pins are now declared in ipq8064 dtsi. Usb phy are enabled by
> default.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 0982b6214fb7..ddc9cc49ab60 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -259,10 +259,6 @@ &gsbi7_serial {
>  	status = "okay";
>  };
>  
> -&hs_phy_1 {
> -	status = "okay";
> -};
> -
>  &nand {
>  	status = "okay";
>  
> @@ -309,15 +305,6 @@ mux {
>  		};
>  	};
>  
> -	mdio0_pins: mdio0_pins {
> -		mux {
> -			pins = "gpio0", "gpio1";
> -			function = "gpio";
> -			drive-strength = <8>;
> -			bias-disable;
> -		};
> -	};
> -

This sets the pins to "gpio". Your earlier patch sets them to "mdio", so
removing this will break MDIO0 on the RB3011. It's likely that your
fixes for MDIO/QCA8K mean that the RB3011 can be switch to use the MDIO
driver rather than mdio-gpio, but that will need tested and this change
alone will definitely break things.

>  	mdio1_pins: mdio1_pins {
>  		mux {
>  			pins = "gpio10", "gpio11";
> @@ -358,10 +345,6 @@ mux {
>  	};
>  };
>  
> -&ss_phy_1 {
> -	status = "okay";
> -};
> -
>  &usb3_1 {
>  	pinctrl-0 = <&usb1_pwr_en_pins>;
>  	pinctrl-names = "default";
> -- 
> 2.34.1
> 

J.

-- 
/-\                             |  Even the Evening Herald slags me
|@/  Debian GNU/Linux Developer |                off.
\-                              |