linux-kernel - [PATCH] sched: Fix stale try_invoke_on_locked_down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220218152328.883437-1-void@manifault.com>
Date:   Fri, 18 Feb 2022 07:23:29 -0800
From:   David Vernet <void@...ifault.com>
To:     peterz@...radead.org, linux-kernel@...r.kernel.org
Cc:     void@...ifault.com, kernel-team@...com, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com
Subject: [PATCH] sched: Fix stale try_invoke_on_locked_down_task comment

In 9b3c4ab3045e, try_invoke_on_locked_down_task() was renamed to
task_call_func(), and several callers, comments, etc were updated to use
the new name and signature. There was one comment in try_to_wake_up() that
was missed, and still refers to the old name. This diff corrects that
comment to refer to the new name.

Fixes: 9b3c4ab3045e ("sched,rcu: Rework try_invoke_on_locked_down_task()")
Signed-off-by: David Vernet <void@...ifault.com>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1e08b02e0cd5..d76e3da0d7d6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4042,7 +4042,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
 	 * Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
 	 * __schedule().  See the comment for smp_mb__after_spinlock().
 	 *
-	 * A similar smb_rmb() lives in try_invoke_on_locked_down_task().
+	 * A similar smb_rmb() lives in task_call_func().
 	 */
 	smp_rmb();
 	if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags))
-- 
2.30.2