linux-kernel - Re: [PATCH 1/4] x86/kvm: remove a redundant variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yg/E71MbiFWq9A0p@google.com>
Date:   Fri, 18 Feb 2022 16:10:23 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Peng Hao <flyingpenghao@...il.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4]  x86/kvm: remove a redundant variable

Similar comments to the other patch.  "KVM: VMX:" for the scope, and a more descriptive
shortlog.

Also, this patch isn't part of a series, it should be simply "PATCH", not "patch 1/4".

On Fri, Feb 18, 2022, Peng Hao wrote:
> variable 'cpu' is defined repeatedly.

The changelog should make it clear why it's ok to remove the redundant variable.
E.g.

  KVM: VMX: Remove scratch 'cpu' variable that shadows an identical scratch var

  Remove a redundant 'cpu' declaration from inside an if-statement that
  that shadows an identical declaration at function scope.  Both variables
  are used as scratch variables in for_each_*_cpu() loops, thus there's no
  harm in sharing a variable.

With that,

Reviewed-by: Sean Christopherson <seanjc@...gle.com>

> Signed-off-by: Peng Hao <flyingpeng@...cent.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index ba66c171d951..6101c2980a9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7931,7 +7931,6 @@ static int __init vmx_init(void)
>  	    ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED &&
>  	    (ms_hyperv.nested_features & HV_X64_ENLIGHTENED_VMCS_VERSION) >=
>  	    KVM_EVMCS_VERSION) {
> -		int cpu;
>  
>  		/* Check that we have assist pages on all online CPUs */
>  		for_each_online_cpu(cpu) {
> -- 
> 2.27.0
>