linux-kernel - Re: [PATCH] mm/mmu_notifiers: use helper function mmu_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c7074b4-5d84-d690-d14a-18c06eacc7a0@huawei.com>
Date:   Fri, 18 Feb 2022 09:49:33 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/mmu_notifiers: use helper function
 mmu_notifier_synchronize()

On 2022/2/17 23:50, Jason Gunthorpe wrote:
> On Thu, Feb 17, 2022 at 07:09:48PM +0800, Miaohe Lin wrote:
>> Use helper function mmu_notifier_synchronize() to ensure all mmu_notifiers
>> are freed. Minor readability improvement.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>>  mm/mmu_notifier.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> I'm not keen on this, the internal synchronize_srcu's don't have the
> same usage model as described in the comment for
> mmu_notifier_synchronize(). Instead they are doing what their comments
> say.
> 
> Yes, it is the same code, but the purpose is different.
> 

Yep, this is my overlook. Many thanks for reply.

> Jason
> .
>