linux-kernel - Re: [PATCH v8 net-next 01/10] dt-bindings: net: dsa: dt bindings for microchip lan937x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b3a954cde4e9d1b6a94991964eb21e80278a8ab.camel@microchip.com>
Date:   Fri, 18 Feb 2022 22:08:55 +0530
From:   Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
To:     Florian Fainelli <f.fainelli@...il.com>, <andrew@...n.ch>,
        <netdev@...r.kernel.org>, <olteanv@...il.com>, <robh+dt@...nel.org>
CC:     <UNGLinuxDriver@...rochip.com>, <woojung.huh@...rochip.com>,
        <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <vivien.didelot@...il.com>,
        <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v8 net-next 01/10] dt-bindings: net: dsa: dt bindings
 for microchip lan937x

On Fri, 2022-02-11 at 19:56 -0800, Florian Fainelli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On 2/9/2022 3:58 AM, Prasanna Vengateshan wrote:
> > On Mon, 2022-02-07 at 18:53 -0800, Florian Fainelli wrote:
> > > 
> > > > +                rx-internal-delay-ps:
> > > > +                  $ref: "#/$defs/internal-delay-ps"
> > > > +                tx-internal-delay-ps:
> > > > +                  $ref: "#/$defs/internal-delay-ps"
> > > 
> > > Likewise, this should actually be changed in ethernet-controller.yaml
> > 
> > There is *-internal-delay-ps property defined for mac in ethernet-
> > controller.yaml. Should that be changed like above?
> 
> It seems to me that these properties override whatever 'phy-mode'
> property is defined, but in premise you are right that this is largely
> applicable to RGMII only. I seem to recall that the QCA8K driver had
> some sort of similar delay being applied even in SGMII mode but I am not
> sure if we got to the bottom of this.
> 
> Please make sure that this does not create regressions for other DTS in
> the tree before going with that change in ethernet-controller.yaml.

Okay, Can these be submitted as a seperate patch?

Prasanna V