linux-kernel - Re: [PATCH 01/22] parisc: pci-dma: remove stale code and comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220219070731.GA26505@lst.de>
Date:   Sat, 19 Feb 2022 08:07:31 +0100
From:   Christoph Hellwig <hch@....de>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, hch@....de, cl@...ux.com,
        42.hyeyoo@...il.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, vbabka@...e.cz, David.Laight@...LAB.COM,
        david@...hat.com, herbert@...dor.apana.org.au, davem@...emloft.net,
        linux-crypto@...r.kernel.org, steffen.klassert@...unet.com,
        netdev@...r.kernel.org, hca@...ux.ibm.com, gor@...ux.ibm.com,
        agordeev@...ux.ibm.com, borntraeger@...ux.ibm.com,
        svens@...ux.ibm.com, linux-s390@...r.kernel.org, michael@...le.cc,
        linux-i2c@...r.kernel.org, wsa@...nel.org
Subject: Re: [PATCH 01/22] parisc: pci-dma: remove stale code and comment

On Sat, Feb 19, 2022 at 08:52:00AM +0800, Baoquan He wrote:
> The gfp assignment has been commented out in ancient times, combined with
> the code comment, obviously it's not needed since then. Let's remove the
> whole ifdeffery block so that GFP_DMA searching won't point to this.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>