linux-kernel - Re: [PATCH 4/7] hwmon: (dell-smm) Improve temperature sensors detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220219145132.GA1033025@roeck-us.net>
Date:   Sat, 19 Feb 2022 06:51:32 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Armin Wolf <W_Armin@....de>
Cc:     pali@...nel.org, jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] hwmon: (dell-smm) Improve temperature sensors
 detection

On Tue, Feb 15, 2022 at 08:11:10PM +0100, Armin Wolf wrote:
> On the Dell Inspiron 3505, three temperature sensors are
> available through the SMM interface. However since they
> do not have an associated type, they are not detected.
> Probe for those sensors in case no type was detected.
> _i8k_get_temp() is used instead of i8k_get_temp()
> since it is sometimes faster and the result is
> easier to check (no -ENODATA) since we do not
> care about the actual temp value.
> 
> Tested on a Dell Inspiron 3505.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/dell-smm-hwmon.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> --
> 2.30.2
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index a102034a1d38..b7016971bb2e 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -655,6 +655,11 @@ static umode_t dell_smm_is_visible(const void *drvdata, enum hwmon_sensor_types
>  	case hwmon_temp:
>  		switch (attr) {
>  		case hwmon_temp_input:
> +			/* _i8k_get_temp() is fine since we do not care about the actual value */
> +			if (data->temp_type[channel] >= 0 || _i8k_get_temp(channel) >= 0)
> +				return 0444;
> +
> +			break;
>  		case hwmon_temp_label:
>  			if (data->temp_type[channel] >= 0)
>  				return 0444;