linux-kernel - Re: [PATCH v8 0/6] serial: mvebu-uart: Support for higher baudrates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220219152622.mykr2zl5cl3rgsgx@pali>
Date:   Sat, 19 Feb 2022 16:26:22 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Marek Behún <kabel@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Gregory Clement <gregory.clement@...tlin.com>,
        linux-clk@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 0/6] serial: mvebu-uart: Support for higher baudrates

Hello Stephen!

On Friday 11 February 2022 20:12:32 Marek Behún wrote:
> Hello Greg, Stephen, Gregory,
> 
> at Pali's request I have reviewed, updated and tested his series adding
> support for higher baudrates on Marvell Armada A37xx boards.
> 
> I have updated commit messages, some comments and indentation at some
> places. As per Stephen Boyd's request, commit message of patch 3 now
> contains more information about why we need to have UART
> clock-controller binding defined in such a way (due to backwards
> compatibility).

Are updated commit messages better now?

> Marek
> 
> Changes in v7:
> * fixed lint errors in yaml binding file
> * added Reviewed-by tags
> * changed commit messages and comments a little
> * fixed indentation at some places
> * swapped patch 2 and 3 (dt-binding defining new binding should go
>   before the driver adding usage of that new binding)
> 
> Changes in v6:
> * fixed yaml binding file and dts files
> 
> Changes in v5:
> * fixed yaml binding file
> 
> Changes in v4:
> * converted armada3700-uart-clock documentation to YAML
> * split documentation changes into two commits:
>   - first which adds clock documentation
>   - second which updates UART documentation
> 
> Changes in v3:
> v3 is rebased on top of Linus master branch and all already applied patches
> were dropped. There are no changes in patches itself since v2.
> 
> Pali Rohár (6):
>   math64: New DIV_U64_ROUND_CLOSEST helper
>   dt-bindings: mvebu-uart: document DT bindings for
>     marvell,armada-3700-uart-clock
>   serial: mvebu-uart: implement UART clock driver for configuring UART
>     base clock
>   dt-bindings: mvebu-uart: update information about UART clock
>   arm64: dts: marvell: armada-37xx: add device node for UART clock and
>     use it
>   serial: mvebu-uart: implement support for baudrates higher than 230400
>     Bd
> 
>  .../clock/marvell,armada-3700-uart-clock.yaml |  59 ++
>  .../devicetree/bindings/serial/mvebu-uart.txt |   9 +-
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |  14 +-
>  drivers/tty/serial/Kconfig                    |   1 +
>  drivers/tty/serial/mvebu-uart.c               | 596 +++++++++++++++++-
>  include/linux/math64.h                        |  13 +
>  6 files changed, 671 insertions(+), 21 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml
> 
> -- 
> 2.34.1
>