linux-kernel - Re: [RESEND v13 08/10] ASoC: qcom: Add lpass CPU driver for codec dma control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e279b9ec-92af-1b86-9ea0-09c9c36e1404@quicinc.com>
Date:   Sun, 20 Feb 2022 00:26:42 +0530
From:   "Srinivasa Rao Mandadapu (Temp)" <quic_srivasam@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <alsa-devel@...a-project.org>, <bgoswami@...eaurora.org>,
        <bjorn.andersson@...aro.org>, <broonie@...nel.org>,
        <devicetree@...r.kernel.org>, <judyhsiao@...omium.org>,
        <lgirdwood@...il.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <perex@...ex.cz>,
        <quic_plai@...cinc.com>, <robh+dt@...nel.org>,
        <rohitkr@...eaurora.org>, <srinivas.kandagatla@...aro.org>,
        <tiwai@...e.com>
CC:     Venkata Prasad Potturu <quic_potturu@...cinc.com>
Subject: Re: [RESEND v13 08/10] ASoC: qcom: Add lpass CPU driver for codec dma
 control


On 2/18/2022 1:23 AM, Stephen Boyd wrote:
Thanks for Your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-02-16 01:42:42)
>> On 2/15/2022 7:03 AM, Stephen Boyd wrote:
>> Thanks for your time Stephen!!!
>>> Quoting Srinivasa Rao Mandadapu (2022-02-14 06:58:26)
>>>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>>>> +       struct lpaif_dmactl *dmactl;
>>>> +       int ret = 0, id;
>>>> +
>>>> +       switch (cmd) {
>>>> +       case SNDRV_PCM_TRIGGER_START:
>>>> +       case SNDRV_PCM_TRIGGER_RESUME:
>>>> +       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>>>> +               __lpass_platform_codec_intf_init(dai, substream);
>>>> +               break;
>>>> +       case SNDRV_PCM_TRIGGER_STOP:
>>>> +       case SNDRV_PCM_TRIGGER_SUSPEND:
>>>> +       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>>> +               __lpass_get_dmactl_handle(substream, dai, &dmactl, &id);
>>>> +               if (!dmactl) {
>>>> +                       dev_err(soc_runtime->dev, "failed to get dmactl handle\n");
>>> This same message is in many places. I really hope it never gets printed
>>> because finding out which line it got printed at is going to be
>>> impossible.
>> Okay. Will add function name in each print.
> Are they useful prints at all? They seem like development prints that
> won't trigger after the driver is developed. Why can't we just remove
> them?
Okay. Will remove prints.