linux-kernel - Re: [PATCH 2/3] staging: r8188eu: refactor rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb7db1ac-8e7e-d549-a5c0-fcd072ae815e@gmail.com>
Date:   Sun, 20 Feb 2022 19:20:40 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Michael Straube <straube.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: r8188eu: refactor rtw_ch2freq()

Hi Michael,

On 2/20/22 18:48, Michael Straube wrote:
> -static int ch_freq_map_num = ARRAY_SIZE(ch_freq_map);
> -
>   u32 rtw_ch2freq(u32 channel)
>   {
> -	u8	i;
> -	u32	freq = 0;
> -
> -	for (i = 0; i < ch_freq_map_num; i++) {
> -		if (channel == ch_freq_map[i].channel) {
> -			freq = ch_freq_map[i].frequency;
> -				break;
> -		}
> -	}
> -	if (i == ch_freq_map_num)
> -		freq = 2412;
> -
> -	return freq;
> +	return ch_freq_map[channel - 1];
>   }

What if channel has wrong value? The old code returned some default 
value, but with new one we will hit OOB.





With regards,
Pavel Skripkin