lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 20 Feb 2022 14:31:05 -0300
From:   Marcelo Aloisio da Silva <marcelo.as@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unnecessary braces in if
 statements

On Fri, Feb 18, 2022 at 03:50:58PM +0300, Dan Carpenter wrote:
> On Fri, Feb 18, 2022 at 02:44:55PM +0300, Dan Carpenter wrote:
> > On Fri, Feb 18, 2022 at 01:37:05AM -0300, Marcelo Aloisio da Silva wrote:
> > > Braces are not necessary for single statement blocks.
> > > 
> > > Signed-off-by: Marcelo Aloisio da Silva <marcelo.as@....com>
> > > ---
> > >  drivers/staging/r8188eu/core/rtw_mlme.c | 8 ++------
> > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> > > index 45eff3018d73..ad1d73a27548 100644
> > > --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> > > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> > > @@ -1379,10 +1379,8 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter)
> > >  	if (pregistrypriv->wifi_spec == 1) {
> > >  		struct wifidirect_info *pwdinfo = &adapter->wdinfo;
> > >  		if (rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE))
> > > -		{
> > >  			/* auto site survey */
> > >  			rtw_auto_scan_handler(adapter);
> > > -		}
> > 
> > Generally we prefer if statements around multi-line indents.  It helps
> 
> I meant "prefer curly braces around multi-line indents".
> 
> regards,
> dan carpenter
> 
Thanks Dan for the feedback.
I'll fix the brace for this if statement in another patch.

Regards,
Marcelo

Powered by blists - more mailing lists