linux-kernel - Re: [PATCH v5 5/8] media: staging: tegra-vde: Bump BSEV DMA timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92f821cd-5fff-9dca-7e63-e33dfc7b391a@gmail.com>
Date:   Mon, 21 Feb 2022 01:53:51 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Nicolas Dufresne <nicolas@...fresne.ca>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/8] media: staging: tegra-vde: Bump BSEV DMA timeout

20.02.2022 23:46, Dmitry Osipenko пишет:
> BSEV DMA timeouts if VDE is downclocked by x10. Bump the timeout to allow
> DMA to complete. We don't support freq scaling yet, this is just a minor
> improvement which may become useful sometime later.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  drivers/staging/media/tegra-vde/h264.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/tegra-vde/h264.c b/drivers/staging/media/tegra-vde/h264.c
> index a46c648a26c6..d8e5534e80c8 100644
> --- a/drivers/staging/media/tegra-vde/h264.c
> +++ b/drivers/staging/media/tegra-vde/h264.c
> @@ -135,7 +135,7 @@ static int tegra_vde_wait_bsev(struct tegra_vde *vde, bool wait_dma)
>  		return 0;
>  
>  	err = readl_relaxed_poll_timeout(vde->bsev + INTR_STATUS, value,
> -					 !(value & BSE_DMA_BUSY), 1, 100);
> +					 !(value & BSE_DMA_BUSY), 1, 1000);
>  	if (err) {
>  		dev_err(dev, "BSEV DMA timeout\n");
>  		return err;

For the reference: This is a new patch in v4/v5 and I didn't intend to
include it into this patchset, it happened by accident. On the other
hand, this patch is harmless, so it's okay to keep it.