linux-kernel - [PATCH 04/11] kernel/fork: move threads-max sysctl to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220220060041.13531-1-tangmeng@uniontech.com>
Date:   Sun, 20 Feb 2022 14:00:41 +0800
From:   tangmeng <tangmeng@...ontech.com>
To:     mcgrof@...nel.org, keescook@...omium.org, yzaikin@...gle.com
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        nizhen@...ontech.com, zhanglianjie@...ontech.com,
        nixiaoming@...wei.com, tangmeng <tangmeng@...ontech.com>
Subject: [PATCH 04/11] kernel/fork: move threads-max sysctl to its own file

kernel/sysctl.c is a kitchen sink where everyone leaves their dirty
dishes, this makes it very difficult to maintain.

To help with this maintenance let's start by moving sysctls to places
where they actually belong.  The proc sysctl maintainers do not want to
know what sysctl knobs you wish to add for your own piece of code, we
just care about the core logic.

All filesystem syctls now get reviewed by fs folks. This commit
follows the commit of fs, move the threads-max sysctl to its
own file, kernel/fork.c.

Signed-off-by: tangmeng <tangmeng@...ontech.com>
---
 include/linux/sysctl.h |  3 ---
 kernel/fork.c          | 22 +++++++++++++++++++++-
 kernel/sysctl.c        |  7 -------
 3 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
index e00bf436d63b..1d3467b5e2f3 100644
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -295,7 +295,4 @@ static inline void do_sysctl_args(void)
 }
 #endif /* CONFIG_SYSCTL */
 
-int sysctl_max_threads(struct ctl_table *table, int write, void *buffer,
-		size_t *lenp, loff_t *ppos);
-
 #endif /* _LINUX_SYSCTL_H */
diff --git a/kernel/fork.c b/kernel/fork.c
index d75a528f7b21..0ac42feb3f71 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -3143,7 +3143,8 @@ int unshare_files(void)
 	return 0;
 }
 
-int sysctl_max_threads(struct ctl_table *table, int write,
+#ifdef CONFIG_SYSCTL
+static int sysctl_max_threads(struct ctl_table *table, int write,
 		       void *buffer, size_t *lenp, loff_t *ppos)
 {
 	struct ctl_table t;
@@ -3165,3 +3166,22 @@ int sysctl_max_threads(struct ctl_table *table, int write,
 
 	return 0;
 }
+
+static struct ctl_table kern_fork_table[] = {
+	{
+		.procname       = "threads-max",
+		.data           = NULL,
+		.maxlen         = sizeof(int),
+		.mode           = 0644,
+		.proc_handler   = sysctl_max_threads,
+	},
+	{ }
+};
+
+static __init int kernel_fork_sysctls_init(void)
+{
+	register_sysctl_init("kernel", kern_fork_table);
+	return 0;
+}
+late_initcall(kernel_fork_sysctls_init);
+#endif /* CONFIG_SYSCTL */
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 126d47e8224d..e6d99bbf9a9d 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1829,13 +1829,6 @@ static struct ctl_table kern_table[] = {
 		.proc_handler	= proc_do_cad_pid,
 	},
 #endif
-	{
-		.procname	= "threads-max",
-		.data		= NULL,
-		.maxlen		= sizeof(int),
-		.mode		= 0644,
-		.proc_handler	= sysctl_max_threads,
-	},
 	{
 		.procname	= "usermodehelper",
 		.mode		= 0555,
-- 
2.20.1