linux-kernel - Re: [PATCH v2 2/2] usb: serial: Fix Coding Style Error Around Ternary Operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhNd6R3WtSIfjnY8@hovoldconsulting.com>
Date:   Mon, 21 Feb 2022 10:39:53 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Husni Faiz <ahamedhusni73@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] usb: serial: Fix Coding Style Error Around
 Ternary Operator

On Sun, Feb 20, 2022 at 06:44:05PM +0530, Husni Faiz wrote:
> This patch fixes "spaces required around that '?'"  checkpatch error
> Added a space before the "?" ternary operator.
> 
> Signed-off-by: Husni Faiz <ahamedhusni73@...il.com>
> ---
> V1->V2 : Separated the style changes into multiple patches.
> 
>  drivers/usb/serial/cp210x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 8a60c0d56863..1fcdfb7d118c 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -1403,7 +1403,7 @@ static int cp210x_tiocmget(struct tty_struct *tty)
>  		|((control & CONTROL_RTS) ? TIOCM_RTS : 0)
>  		|((control & CONTROL_CTS) ? TIOCM_CTS : 0)
>  		|((control & CONTROL_DSR) ? TIOCM_DSR : 0)
> -		|((control & CONTROL_RING)? TIOCM_RI  : 0)
> +		|((control & CONTROL_RING) ? TIOCM_RI  : 0)
>  		|((control & CONTROL_DCD) ? TIOCM_CD  : 0);

I'm pretty sure the author intended the TIOCM arguments to be aligned
here.

But in any case, I'm not taking checkpatch.pl clean ups unless you're
also doing real changes to the code in question.

>  	dev_dbg(&port->dev, "%s - control = 0x%02x\n", __func__, control);

Johan